Reviewing Patches to the core
(This is open for debate)
What is the core
Basically anything inside pida/pida, where non-core is defined as pida/pida-plugins and pida/tools.
There are some exceptions like:
- Docstrings
- Translations/Locales
- Text string typos in the user interface, or messages
What is the process
- Any change to the code should be accompanied by a Trac ticket.
- The change should be attached to the ticket as a patch.
- The patch should be reviewed by any other developer.
How should reviewers handle things
We must aim to create and maintain a very high quality codebase. For this reason, reviewers should be difficult to please.
Discussions
Mailing list or IRC
Possible Reviewers
Any other developer
What if there is disagreement
The project maintainer (Ali for now) will make the final decision.
